Ensure scratch directory exists when calling extractCache #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chagui-
force-pushed
the
patch-1
branch
3 times, most recently
from
2398406 to
fd82f47
Compare
|
Thanks, but CI is failing |
|
yeah i forgot to build, so i did, then i was missing the signed off so i added it following the instructions (which added a new commit). But the the pipeline was mad because the last commit didn't contain the build. I reverted and now everything should be contained in a single commit. |
|
Not sure why its failing now |
|
Please try this buildkit-cache-dance/.github/workflows/unit-tests.yml Lines 17 to 26 in 5de31fc |
Signed-off-by: Andres Peñaloza <[email protected]>
|
I did try that but it was not updating anything in the dist folder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the action for the first time and no cache exists, inject does not get called, so scratch dir is not created. Then extracting the cache fails because it tries to write to
scratch/buildstampbut the scratch folder does not exist.Workaround is to chance the scrath folder to some other folder that already exists:
This PR ensures the directory exists even if the inject job is not called. Should fix #23